Making DataFrameMapper compatible with GridSearchCV #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, an attempt to implement the proposal from issue #159 is made. The idea is to write custom
get_params
andset_params
methods that are compatible withscikit-learn
grid search objects.The following snippet shows features supported:
We still need to add more tests and think about possible edge cases. For example, I am not sure how to handle this case:
Also, I think that the current implementation of
set_params
could be revised/optimized, and we can handleget_params
andset_params
for cases when all the transformed columns have only a single transformer usingPipeline
class instead of writing a custom code.Would be glad to know your thoughts and proposals to finalize the PR and make the
DataFrameMapper
grid-search ready.